editor: the modal page has no id-conflict sweep #102

New issue

Open

opened 2026-09-24 12:49:59 +00:00 by bcox · 0 comments

bcox commented

2026-09-24 12:49:59 +00:00

Owner

editor/patch_view_id_conflict_test.cc sweeps the waveguide page (WaveguidePageHasNoDuplicateWidgetIds) and others, but not the modal page. The passive-bridge branch's More strings control (DrawSlotMask, one checkbox per slot under PushID(label) then PushID(i)) is safe by construction and is reached only by editor/modal_binding_test.cc; the Strings tap and Strings controls beside it have the same gap. A sweep for the modal page, in the shape of the waveguide's, would close it.

Predates the passive-bridge branch; noted in its ledger's Follow-ups.

`editor/patch_view_id_conflict_test.cc` sweeps the waveguide page (`WaveguidePageHasNoDuplicateWidgetIds`) and others, but not the modal page. The passive-bridge branch's `More strings` control (`DrawSlotMask`, one checkbox per slot under `PushID(label)` then `PushID(i)`) is safe by construction and is reached only by `editor/modal_binding_test.cc`; the `Strings tap` and `Strings` controls beside it have the same gap. A sweep for the modal page, in the shape of the waveguide's, would close it. Predates the passive-bridge branch; noted in its ledger's Follow-ups.